So I went to the Optical Museum...
Fascinating place, just two rooms but absolutely crammed with stuff. If you are in London and at all interested in the subject, it's well worth a visit. So much to see that it was hard to pick a favourite piece, but I did like the 18th century fans, that have a spyglass lens built into them, so you could pretend to be hiding behind your fan while actually spying on people on the other side of the room. Plus drawers full of old glasses you could try on (some fifties frames to die for.)
Here's me trying on 19th century sunglasses...
some WW2 night vision adaptor goggles, worn by pilots before they flew at night to dark-adapt their eyes.
and some 17th century spectacles made of leather
I could go on, but I'll resist!
Anyway, back to the goggles. The curator's opinion, was that they are definitely post-war. At the very earliest, late 1940s, and more likely to be from the 50s or even 60s. So Trell, you were right and sorry for doubting you. He said they were unlikely to have been meant as driving goggles as people didn't really use them then, more likely some kind of protective visor, though he couldn't say what for. Aviation and skiing were both possibilities, but, a true professional historian, he was unwilling to speculate beyond his knowledge.
Of course I was hoping they were earlier, but I've learned so much! And they are still very cool shades.
The other two glasses were definitely between the wars, probably 1930s.
So thanks everyone for all your input. I thought perhaps I should put the BOA museum website link into the online resources. It's searchable objects catalogue is really useful.
Ruth